Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README usage example #6

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Fix README usage example #6

merged 1 commit into from
Mar 13, 2022

Conversation

DavidChouinard
Copy link
Contributor

The README example is incorrectly missing the new keyword for instantiating the PDLJS class. Caused me a lot of headaches until I found out! Hope it can help others.

@DavidChouinard
Fix README usage example
2e730f6 
The README example is incorrectly missing the `new` keyword for instantiating the `PDLJS` class. Caused me a lot of headaches!
vvillait88
vvillait88 approved these changes Mar 13, 2022
View reviewed changes
Copy link
Contributor

@vvillait88 vvillait88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, sorry for forgetting this. If you look at the example code folder, you can see how to use the library

@vvillait88 vvillait88 merged commit a1628be into peopledatalabs:main Mar 13, 2022
@DavidChouinard
Copy link
Contributor Author

Thanks for merging!

@vvillait88 vvillait88 added the documentation Improvements or additions to documentation label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvillait88 vvillait88 vvillait88 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidChouinard @vvillait88